-
-
Notifications
You must be signed in to change notification settings - Fork 257
Enhancement: Replace print() with log() #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -254,5 +255,10 @@ void noOpLogger(SentryLevel level, String message) {} | |||
|
|||
/// A Logger that prints out the level and message | |||
void dartLogger(SentryLevel level, String message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v6 I'd like to add an error and stacktrace parameter to our loggers.
They can be passed to https://api.flutter.dev/flutter/dart-developer/log.html and look hopefully better
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 89.98% 90.04% +0.05%
==========================================
Files 54 54
Lines 1698 1707 +9
==========================================
+ Hits 1528 1537 +9
Misses 170 170
Continue to review full report at Codecov.
|
/// function. | ||
/// These levels are inspired by | ||
/// https://pub.dev/documentation/logging/latest/logging/Level-class.html | ||
int toLogLevel() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we call toDartLogLevel instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
💡 Motivation and Context
Fixes #451
💚 How did you test it?
📝 Checklist
🔮 Next steps